Skip to content

Conversation

@gownosatana
Copy link
Contributor

This pull request adds quaternion functions for bones which gives more control of bones

Test resource: test.zip

@tederis tederis added the enhancement New feature or request label Aug 26, 2024
@gownosatana
Copy link
Contributor Author

Sorry, forgot to change in header files, now should be good to go

@gownosatana
Copy link
Contributor Author

@tederis

@tederis
Copy link
Member

tederis commented Aug 29, 2024

I would rename these functions to setElementBoneQuaternion and getElementBoneQuaternion. Because setElementBoneRotationQuaternion is oxymoron as quaternion means rotation as well.

@gownosatana
Copy link
Contributor Author

I would rename these functions to setElementBoneQuaternion and getElementBoneQuaternion. Because setElementBoneRotationQuaternion is oxymoron as quaternion means rotation as well.

renamed

@gownosatana gownosatana requested a review from tederis August 29, 2024 11:44
tederis
tederis previously approved these changes Aug 29, 2024
Copy link
Member

@tederis tederis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Copy link
Member

@tederis tederis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tederis
Copy link
Member

tederis commented Sep 10, 2024

Although some of the conversations was marked as resolved without being actually finished I tend to turn a blind eye on it. Non-critical discrepancies in code style should not prevent a good PR from being merged in my opinion.

@tederis tederis merged commit 10098b0 into multitheftauto:master Sep 10, 2024
MTABot pushed a commit that referenced this pull request Sep 10, 2024
@TracerDS TracerDS mentioned this pull request Sep 10, 2024
@Dutchman101
Copy link
Member

Dutchman101 commented Sep 12, 2024

Please document the new functions on wiki, @gownosatana

To be added:
https://wiki.multitheftauto.com/wiki/SetElementBoneQuaternion
https://wiki.multitheftauto.com/wiki/GetElementBoneQuaternion

// Edit: done, but despite the author's failure to do it, someone else did.
For future reference: https://i.imgur.com/Iboa44o.png (it will be a pre-requirement of their next PR's).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants