-
-
Notifications
You must be signed in to change notification settings - Fork 502
Add bone quaternion functions #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry, forgot to change in header files, now should be good to go |
|
I would rename these functions to |
renamed |
tederis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fernando-A-Rocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
tederis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Although some of the conversations was marked as resolved without being actually finished I tend to turn a blind eye on it. Non-critical discrepancies in code style should not prevent a good PR from being merged in my opinion. |
|
Please document the new functions on wiki, @gownosatana To be added: // Edit: done, but despite the author's failure to do it, someone else did. |
This pull request adds quaternion functions for bones which gives more control of bones
Test resource: test.zip